Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spec compliant metric creation and sync instruments #2588

Merged
merged 4 commits into from
Dec 1, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 3, 2021

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #2588 (41b8a00) into main (14afcc1) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2588      +/-   ##
==========================================
- Coverage   93.10%   93.10%   -0.01%     
==========================================
  Files         123      123              
  Lines        4759     4755       -4     
  Branches     1061     1060       -1     
==========================================
- Hits         4431     4427       -4     
  Misses        328      328              
Impacted Files Coverage Δ
...ages/opentelemetry-api-metrics/src/types/Metric.ts 100.00% <0.00%> (ø)

@dyladan dyladan force-pushed the sync-metric-options branch from 4de7823 to 5212d9d Compare November 30, 2021 20:08
@dyladan dyladan marked this pull request as ready for review November 30, 2021 20:52
@dyladan dyladan requested a review from a team November 30, 2021 20:52
@dyladan dyladan merged commit 3959386 into open-telemetry:main Dec 1, 2021
@dyladan dyladan deleted the sync-metric-options branch December 1, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants